Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix module rebuilds that add new dependencies #12567

Merged
merged 3 commits into from
Feb 3, 2021

Conversation

mattcompiles
Copy link
Contributor

Currently, module rebuilds that add new dependencies to the compilation are broken. This is due to the processDependeciesQueue returning the already processed module entry from the queue, rather than re-processing the module.

The fix is to invalidate the module on the queue before calling processModuleDependencies so that it is correctly re-processed.

What kind of change does this PR introduce?

bugfix

Did you add tests for your changes?

Yes 馃憤

Does this PR introduce a breaking change?

No

What needs to be documented once your changes are merged?

Nothing

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we鈥檒l review the pull request soon.

@sokra sokra merged commit 9393124 into webpack:master Feb 3, 2021
@sokra
Copy link
Member

sokra commented Feb 3, 2021

Thanks

@mattcompiles mattcompiles deleted the fix-broken-rebuild branch February 3, 2021 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants