Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/fix husky upgrade #12739

Merged
merged 6 commits into from Feb 22, 2021
Merged

Conversation

chenxsan
Copy link
Member

What kind of change does this PR introduce?

Follow-up of #12630.

husky 5 works quite different from the previous version:

Important Husky v5 brings a lot of improvements but is also very different from v4. Git hooks won't work if you only upgrade husky dependency, existing config needs to be migrated too.

And here's the migration guide https://typicode.github.io/husky/#/?id=migrate-from-v4-to-v5.

Or we just downgrade to v4 as it's still available.

Did you add tests for your changes?

No need.

Does this PR introduce a breaking change?

No.

What needs to be documented once your changes are merged?

Nothing.

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@sokra
Copy link
Member

sokra commented Feb 22, 2021

ah, that explains why it's no longer working... I already wondered and thought it is only a local problem for me.

Sadly the pinst thing is a no-go, since I want github and npm version to be exactly the same and that would break it. It would also break installing from github directly since the postinstall script is executed.

Could we move husky install into the setup script instead?

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@chenxsan
Copy link
Member Author

There's an issue here typicode/husky#868 regarding your concern of pinst. Maybe we can downgrade to v4 at the moment until they figure out a better way?

@sokra sokra enabled auto-merge February 22, 2021 12:38
@sokra sokra merged commit 84c96f8 into webpack:master Feb 22, 2021
@chenxsan chenxsan deleted the bugfix/fix-husky-upgrade branch February 22, 2021 14:12
@chenxsan chenxsan mentioned this pull request Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants