New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance improvements #13448
Performance improvements #13448
Conversation
For maintainers only:
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
for (const entry of exports.values()) { | ||
const name = namesInOrder[i]; | ||
if (entry.name !== name) break; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missing an increment to i
somewhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yes. Do you want to send a PR
What kind of change does this PR introduce?
performance
Did you add tests for your changes?
N/A
Does this PR introduce a breaking change?
no
What needs to be documented once your changes are merged?
nothing