Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update webpack options #13660

Merged
merged 2 commits into from
Jun 29, 2021
Merged

Conversation

chenxsan
Copy link
Member

What kind of change does this PR introduce?

A follow-up of #13622

Did you add tests for your changes?

No need as far as I can tell.

Does this PR introduce a breaking change?

No.

What needs to be documented once your changes are merged?

Nothing.

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@webpack-bot
Copy link
Contributor

@chenxsan The most important CI builds failed. This way your PR can't be merged.

Please take a look at the CI results from azure (0 errors / 0 warnings) and appveyor (failure) and fix these issues.

@sokra
Copy link
Member

sokra commented Jun 29, 2021

Thanks

@chenxsan
Copy link
Member Author

@sokra I just notice it's closed without merging :)

@sokra sokra merged commit 3863b42 into webpack:main Jun 29, 2021
@sokra
Copy link
Member

sokra commented Jun 29, 2021

Sorry, wrong button^^

@chenxsan chenxsan deleted the bugfix/update-webpack-options branch June 30, 2021 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants