-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] feat: add documentation links in schema #13822
base: main
Are you sure you want to change the base?
Conversation
For maintainers only:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chenxsan Maybe we can add built-in redirects (for example https://webpack.js.org/webpack-options/output/chunk-load-timeout
) and use them here, because options can be moved inside our site on other pages it requires update schema very often, using redirect we will solve it
@alexander-akait With the current stacks of the webpack document site (A single page application hosted on github pages), we can't support server side redirects. However we can support client side redirection for urls of Do you think it's reasonable with a pattern like Another option is to host the site on maybe vercel alike service which does support server side redirects. |
@chenxsan I agree server side redirects are better, but maybe we can emulate right now redirects using |
That would require us to generate a lot of intermediate pages as far as I know. E.g., with a url like <meta http-equiv="refresh" content="0; url=https://webpack.js.org/configuration/output/#outputchunkloadtimeout" /> Here's an example we already have https://github.com/webpack/webpack.js.org/blob/gh-pages/loaders/file-loader/index.html which is created by RedirectWebpackPlugin. But I want to remind you that it won't work against urls with a hash like The client side redirect might be the only feasible one besides the server side redirect at the moment. |
@chenxsan Then let's do this for now and improve this in future |
@snitin315 The most important CI builds failed. This way your PR can't be merged. Please take a look at the CI results from azure (1 errors / 0 warnings) and appveyor (success) and fix these issues. |
What kind of change does this PR introduce?
feature, add links to show in the error output.
Did you add tests for your changes?
WIP
Does this PR introduce a breaking change?
no
What needs to be documented once your changes are merged?
Nothing