fix: create contexts in object shorthand syntax #14546

peterq · 2021-10-21T06:56:15Z

What kind of change does this PR introduce?

close #14545

Did you add tests for your changes?

Yes.

Does this PR introduce a breaking change?

No.

What needs to be documented once your changes are merged?

No need.

linux-foundation-easycla · 2021-10-21T06:56:19Z

The committers are authorized under a signed CLA.

webpack-bot · 2021-10-21T06:56:20Z

For maintainers only:

This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
This needs to be backported to webpack 4 (issue will be created when merged)

…ContextDependency

webpack-bot · 2021-10-21T08:31:44Z

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

lib/dependencies/CommonJsRequireContextDependency.js

sokra · 2021-11-02T12:43:47Z

Thanks

fix: create contexts in object shorthand syntax

6c0056c

webpack-bot added the PR: unreviewed label Oct 21, 2021

webpack-bot added the PR: CI-not-ok label Oct 21, 2021

fix: Right-hand side of 'instanceof' is not callable: CommonJsRequire…

2505800

…ContextDependency

webpack-bot added PR: CI-ok and removed PR: CI-not-ok labels Oct 21, 2021

sokra requested changes Nov 2, 2021

View reviewed changes

lib/dependencies/CommonJsRequireContextDependency.js Show resolved Hide resolved

webpack-bot added PR: reviewed-changes-requested and removed PR: unreviewed labels Nov 2, 2021

add comment about serialization

0d617c5

sokra approved these changes Nov 2, 2021

View reviewed changes

webpack-bot added the PR: reviewed-approved label Nov 2, 2021

sokra merged commit 5707f0d into webpack:main Nov 2, 2021

Provide feedback