Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: context resolution #15580 #15581

Closed
wants to merge 3 commits into from
Closed

fix: context resolution #15580 #15581

wants to merge 3 commits into from

Conversation

Tofandel
Copy link

@Tofandel Tofandel commented Mar 24, 2022 •
edited

Fixes #15580

What kind of change does this PR introduce?

Fixes a bug where path resolution is incorrect

Did you add tests for your changes?
Yes

Does this PR introduce a breaking change?
No

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 24, 2022 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Tofandel / name: Adrien Foulon (f8a427c)

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@Tofandel Tofandel marked this pull request as draft March 24, 2022 18:40
@Tofandel Tofandel marked this pull request as ready for review March 24, 2022 20:07
@Tofandel Tofandel changed the title fix: #15580 fix: context resolution #15580 Mar 24, 2022
@vankop
Copy link
Member

vankop commented Mar 25, 2022

answered in issue

@vankop vankop closed this Mar 25, 2022
@Tofandel Tofandel mentioned this pull request Mar 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: unreviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

import.meta.webpackContext doesn't work if requiring inside npm packages
3 participants
@Tofandel @webpack-bot @vankop