fix: avoid double compilation when for context dependencies #16908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For maintainers only:
|
|
@TheLarkInn I think we can add test case for such case, I will look how we can test it |
sokra
reviewed
Apr 5, 2023
| @@ -2565,6 +2565,7 @@ class FileSystemInfo { | |||
| } | |||
| if ( | |||
| snap.timestampHash !== undefined && | |||
| current.timestampHash !== undefined && | |||
There was a problem hiding this comment.
I think this should never be undefined, since it should be computed when its missing.
I think there is some bug somewhere else..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #16886
Summary
馃 Generated by Copilot at f634635
Fix a bug in
FileSystemInfothat could cause an error when checking snapshot validity. Add a condition tocheckSnapshotValidto handle undefined timestamp hashes in file system snapshots.Details
馃 Generated by Copilot at f634635