-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle class name in properties and methods #17233
Merged
+360
−43
Merged
Changes from 17 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
a9e8aac
fix: handle class name in properties and methods
alexander-akait ae66636
test: added
alexander-akait a5c4c1e
test: more
alexander-akait 5ea17cd
test: run only when supports
alexander-akait ae84ff9
test: fix for terser due mangling
alexander-akait 69dcaf1
fix: enable this
alexander-akait d1c4e61
fix: inner graph
alexander-akait 214f7cd
refactor: test and types
alexander-akait 4474dc4
fix: inner graph
alexander-akait 0c17bac
test: added
alexander-akait becfc3d
test: fix
alexander-akait 8c54020
test: fix
alexander-akait cb38d74
refactor: logic and test
alexander-akait 625bf06
test: more
alexander-akait 3d02d0d
test: fix
alexander-akait 563ec33
test: added
alexander-akait fca1703
refactor: rebase
alexander-akait 84629bf
refactor: fix type
alexander-akait File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
import B from "./b.js"; | ||
import { A1 } from "./dep1"; | ||
|
||
export default class A extends B { | ||
constructor() { | ||
super(); | ||
} | ||
test() { | ||
super.test(); | ||
|
||
this.b = new B(); | ||
this.a1 = new A1(); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
import A from "./a.js"; | ||
import { A1 } from "./dep1"; | ||
|
||
export default class B { | ||
constructor() {} | ||
test() { | ||
this.a = new A(); | ||
this.a2 = new A1(); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
import {mixin1, mixin2, mixin3, A, B, C, Y} from "./dep2"; | ||
import {mixin1, mixin2, mixin3, getField, A, B, C, Y, mixin4} from "./dep2"; | ||
|
||
export const A1 = class A1 extends A { | ||
render() {return new E();} | ||
|
@@ -12,7 +12,7 @@ export const C1 = class C1 extends mixin2(Y, /*#__PURE__*/ mixin3(C)) { | |
render() {return new D();} | ||
}; | ||
|
||
export class Y1 extends mixin2(Y) { | ||
export class Y1 extends /*#__PURE__*/ mixin2(Y) { | ||
constructor() { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We use |
||
super(); | ||
|
||
|
@@ -22,5 +22,9 @@ export class Y1 extends mixin2(Y) { | |
render() {return new D();} | ||
} | ||
|
||
export class Bar extends /*#__PURE__*/ mixin4(A) { | ||
[/*#__PURE__*/ getField()] = 12; | ||
} | ||
|
||
export class E {} | ||
const D = class D {}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
import A from "./a.js"; | ||
let a = new A(); | ||
a.test(); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
var supportsClassStaticBlock = require("../../../helpers/supportsClassStaticBlock"); | ||
|
||
module.exports = function (config) { | ||
return supportsClassStaticBlock(); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will fix it late, I am already working on types here, we need rewrite some parts of code