fix: The setStatus() of the HMR module should not return an array, which may cause infinite recursion.

[System233]

Summary

🤖 Generated by Copilot at d293083

Fix unhandled promise rejections in HotModuleReplacement.runtime.js. Add an empty callback to Promise.all in setStatus to handle any status without handlers.

The setStatus() of the HMR module should not return an array, which may cause infinite recursion.

Related issues

Fixes #16972, #13857, #13876, #13877

Details

🤖 Generated by Copilot at d293083

• Add an empty callback to Promise.all in setStatus to prevent unhandled rejections (link)

PR #13576 Incorrectly makes the setStatus method in the HMR module return an array.

webpack/lib/hmr/HotModuleReplacement.runtime.js

Lines 211 to 219 in e852415

	function setStatus(newStatus) {
	currentStatus = newStatus;
	var results = [];
	for (var i = 0; i < registeredStatusHandlers.length; i++)
	results[i] = registeredStatusHandlers[i].call(null, newStatus);
	return Promise.all(results);
	}

before that:

webpack/lib/hmr/HotModuleReplacement.runtime.js

Lines 210 to 214 in 795b4b7

	function setStatus(newStatus) {
	currentStatus = newStatus;
	for (var i = 0; i < registeredStatusHandlers.length; i++)
	registeredStatusHandlers[i].call(null, newStatus);
	}

In the absence of $hmrDownloadManifest$, this array will be passed to the next then function, causing the if(!update) condition to fail,

webpack/lib/hmr/HotModuleReplacement.runtime.js

Lines 251 to 257 in e852415

	return setStatus("check")
	.then($hmrDownloadManifest$)
	.then(function (update) {
	if (!update) {
	return setStatus(applyInvalidatedModules() ? "ready" : "idle");
	}

resulting in infinite recursion in here:

webpack/hot/poll.js

Lines 13 to 24 in 1f99ad6

	var checkForUpdate = function checkForUpdate(fromUpdate) {
	if (module.hot.status() === "idle") {
	module.hot
	.check(true)
	.then(function (updatedModules) {
	if (!updatedModules) {
	if (fromUpdate) log("info", "[HMR] Update applied.");
	return;
	}
	require("./log-apply-result")(updatedModules, updatedModules);
	checkForUpdate(true);
	})

Furthermore, since updatedModules is an empty array, this code will endlessly print [HMR] Nothing hot updated. to the console:

webpack/hot/log-apply-result.js

Lines 26 to 28 in 1f99ad6

	if (!renewedModules || renewedModules.length === 0) {
	log("info", "[HMR] Nothing hot updated.");
	} else {

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: System233 (d293083, b0defae)

[webpack-bot]

For maintainers only:

• This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
• This needs to be backported to webpack 4 (issue will be created when merged)

[alexander-akait]

Can you provide reproducble example with the problem? I am not sure it is really fix the problem in right way

[System233]

Can you provide reproducble example with the problem? I am not sure it is really fix the problem in right way

Take a look: https://github.com/System233/webpack-hmr-bug-replay.git

[System233]

Under certain target configurations, when the workerChunkLoading default value is interpreted as false or when the ModuleChunkLoadingRuntimeModule is utilized, it leads to hmrDownloadManifest being undefined. Consequently, this renders the subsequent 'then' call ineffective.

[rupasix]

I'm testing that PR because of random Nothing hot updated infinite loops when project is on idle for few minutes. My observations is: hmr and manual page reload is so much, MUCH faster and no infinite loops.

[callmeteus]

I'm actually facing this issue and this PR solved it for me.
I think it should be merged ASAP.

[alexander-akait]

Sorry for delay and thank you