feat: support node: prefix for Node.js core modules in runtime code
#18316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For maintainers only:
|
|
@vankop I want to drop azure CI, it is slow and often failed, what do you think? |
|
you are right, but ci speed in general slow.. maybe keep it for stability, we can force merge anyway. |
alexander-akait
commented
Apr 12, 2024
| /^(async-)?node(\d+(?:\.(\d+))?)?$/, | ||
| (asyncFlag, major, minor) => { | ||
| /^(async-)?node((\d+)(?:\.(\d+))?)?$/, | ||
| (asyncFlag, _, major, minor) => { |
There was a problem hiding this comment.
Bugfix, before when you have 14.18 - major was 14.18 and minor was 18, so if you have node14.8 in your target, you always have true, same here for other places
There was a problem hiding this comment.
Looks like nobody used it before 😄
|
I've created an issue to document this in webpack/webpack.js.org. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
fixes #18277
Did you add tests for your changes?
Yes
Does this PR introduce a breaking change?
No, because we generate it only when your env supported it
What needs to be documented once your changes are merged?
Yes
Shorty:
We generate
node:prefix forimport ... from "module"only when your env supported it and it is only abour webpack runtime code. We need document that you can disable it using theoutput.environment.nodePrefixForCoreModulesoption