[WIP] Hooks for subresource integrity #1868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -160,7 +160,8 @@ Stats.prototype.toJson = function toJson(options, forToString) { | |||
| size: compilation.assets[asset].size(), | |||
| chunks: [], | |||
| chunkNames: [], | |||
| emitted: compilation.assets[asset].emitted | |||
| emitted: compilation.assets[asset].emitted, | |||
| x: compilation.assets[asset].x || {} | |||
There was a problem hiding this comment.
please remove this change from this PR.
jscheid
force-pushed
the
1800/subresource-integrity
branch
from
2923430
to
d4db20a
Compare
sokra
added a commit
that referenced
this pull request
Jan 9, 2016
[WIP] Hooks for subresource integrity
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new plugin hook that allows adding additional attributes to dynamically created script tags.
@sokra for discussion:
webpack-subresource-integritywould need the following contract for thejsonp-scripthook: that there is a variable namedscriptin scope, bound to the newly created script element, and a variablechunkIdbound to the respective chunk ID. Can this be codified somehow, or can you think of an alternate approach that doesn't require the plugin code to rely on well-known variable names?require-ensureplugin hook. Do we need to add tests for thejsonp-scripthook? If so, where would they go?