Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update loader utils dependency to fix #3060 #3064

Merged
merged 1 commit into from
Sep 27, 2016
Merged

Conversation

lukeapage
Copy link
Contributor

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Other information:

Raising so it won't be forgotten, since #3060 was closed for some reason.

@SpaceK33z
Copy link
Member

With semver this isn't necessary...

@Jessidhia
Copy link
Member

Jessidhia commented Sep 27, 2016

@SpaceK33z it is not necessary for new installs, but it is for update installs. npm won't bother updating nested dependencies if their versions still pass the semver check.

It also, semantically, means that versions as old as 0.2.11 should work, but it actually doesn't. Arguably that is loader-utils' fault for not doing a semver-minor bump for an API change, but as its semver-major is still 0, there are, according to semver, no API compatibility requirements.

@sokra sokra merged commit f02b993 into webpack:master Sep 27, 2016
@sokra
Copy link
Member

sokra commented Sep 27, 2016

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants