Limit number of files processed asynchronously #3166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 20, 2016
Closed
sokra
requested changes
Dec 7, 2016
| @@ -232,7 +232,8 @@ Compiler.prototype.emitAssets = function(compilation, callback) { | |||
| function emitFiles(err) { | |||
| if(err) return callback(err); | |||
|
|
|||
| require("async").forEach(Object.keys(compilation.assets), function(file, callback) { | |||
| var async = require("async"); | |||
| async.forEachLimit(Object.keys(compilation.assets), process.env.WEBPACK_FILE_LIMIT || 1000, async.ensureAsync(function(file, callback) { | |||
There was a problem hiding this comment.
Don't use environment variables, instead use a configuration value.
| @@ -232,7 +232,8 @@ Compiler.prototype.emitAssets = function(compilation, callback) { | |||
| function emitFiles(err) { | |||
| if(err) return callback(err); | |||
|
|
|||
| require("async").forEach(Object.keys(compilation.assets), function(file, callback) { | |||
| var async = require("async"); | |||
There was a problem hiding this comment.
async will become a reversed keyword, rename it.
There was a problem hiding this comment.
@sokra what name should be preferred for the var? asyncLib? Might be worth it to make a PR rewriting all uses of async as an identifier.
|
This PR should be done against the master branch not only webpack 1 |
|
see #5502 |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
OS file limit is reached by processing too many files at the same time.
What is the new behavior?
Limits the number of files to 1000 or set by an environment variable. (Maybe it should be even lower ~500)
Does this PR introduce a breaking change?
Other information:
Resolves #3164