Update node-libs-browser to ^1.1.0 #3355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to webpack/node-libs-browser#45, the risk of introducing a breaking change with this update is very low.
This was referenced Nov 23, 2016
|
This branch should not be merged. I just discovered that browserify-crypto does indeed introduce a breaking change unintentionally – by requiring json files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Dependency update
Summary
Since node-libs-browser 1.0.0 was released as a major version and only webpack 2 was updated, we had to maintain a
version-0branch for webpack 1. We should update webpack 1 as well so we don't have to maintain two branches.Does this PR introduce a breaking change?
According to my research, the risk of introducing a breaking change with this update is very low. node-libs-browser is designed to be in feature parity with node, but the exact node version is not pinned. So this is somewhat vague. If someone relied on a very ancient node feature or a bug that has been fixed, this would be a breaking change. But it is also likely that this update could fix some bugs for free. We actually had already some requests to update a node module in webpack-1 (webpack/node-libs-browser#39, webpack/node-libs-browser#40)