New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No errors plugin deprecate #3570
Changes from 7 commits
919ac0d
c22ac25
f6fe298
d70be66
ada8e29
cfd06c2
f68d57b
5e1ab1b
74532e5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
/* | ||
MIT License http://www.opensource.org/licenses/mit-license.php | ||
Author Tobias Koppers @sokra | ||
*/ | ||
function NoEmitOnErrorsPlugin() {} | ||
|
||
module.exports = NoEmitOnErrorsPlugin; | ||
NoEmitOnErrorsPlugin.prototype.apply = function(compiler) { | ||
compiler.plugin("should-emit", function(compilation) { | ||
if(compilation.errors.length > 0) | ||
return false; | ||
}); | ||
compiler.plugin("compilation", function(compilation) { | ||
compilation.plugin("should-record", function() { | ||
if(compilation.errors.length > 0) | ||
return false; | ||
}); | ||
}); | ||
}; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
require('./file'); | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
module.exports = function a() { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These files should not be commited. They are only create temporary by the test suite. You probably canceled tests before they are remove. If you want to you could add them to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, canceled before test suite was entirely done. Will remove them and ignore them as well. Thanks @sokra! |
||
return "This is a"; | ||
}; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
module.exports = function b() { | ||
require("./a"); | ||
return "This is c"; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Write a test case with error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do!