don't shorten node_modules to ~ #4144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sokra
force-pushed
the
fix/node_modules_mangle
branch
from
db9a24a
to
13a9a70
Compare
it's confusing
sokra
force-pushed
the
fix/node_modules_mangle
branch
from
13a9a70
to
dca8e62
Compare
|
Is there an issue we can tie to this? Just to track. |
|
@sokra Thank you so much for working on this. |
sokra
force-pushed
the
fix/node_modules_mangle
branch
from
726e7cf
to
26f79f5
Compare
Closed
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
change, fix
Did you add tests for your changes?
not yet
If relevant, link to documentation update:
n/a
Summary
don't shorten node_modules to ~
it's confusing
Does this PR introduce a breaking change?
yes
Other information