WIP: Use babylon as the parser #4308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzoo
commented
Feb 18, 2017
lib/Parser.js
Outdated
| @@ -536,8 +536,10 @@ Parser.prototype.walkForOfStatement = function walkForOfStatement(statement) { | |||
|
|
|||
| // Declarations | |||
| Parser.prototype.walkFunctionDeclaration = function walkFunctionDeclaration(statement) { | |||
| this.scope.renames["$" + statement.id.name] = undefined; | |||
| this.scope.definitions.push(statement.id.name); | |||
| if(statement.id) { | |||
There was a problem hiding this comment.
Temporary fix
Ref estree/estree#98
the error before was trying to access name of null (since id is null) for export default function() {}
Acorn: FunctionExpression
Babel: FunctionDeclaration + null id
Need to figure out why https://github.com/hzoo/webpack/blob/test-babylon/test/cases/parsing/issue-2570/fn.js
turns into
webpack + babylon
/***/ (function(module, __webpack_exports__, __webpack_require__) {
"use strict";
function() { return [].slice.call(arguments); } // invalid
/***/ }),webpack master + acorn
/***/ (function(module, __webpack_exports__, __webpack_require__) {
"use strict";
/* harmony default export */ __webpack_exports__["a"] = (function() { return [].slice.call(arguments); });
/***/ }),
|
I ran a build against I use the programmatic API from Webpack. I had issues linking modules with npm, I ended up requiring directly the module: + "webpack": "git@github.com:hzoo/webpack.git#test-babylon",
- "webpack": "^2.2.0-rc.1", |
|
I guess you won't continue this? Can this be closed or do you want to rebase it to get more results? |
|
It should be fixed after that acorn change, I can rebase |
hzoo
force-pushed
the
test-babylon
branch
3 times, most recently
from
c9dd163
to
ac193f9
Compare
|
How is |
|
Yeah, every available parser seems to fundamentally error on that, apart from acorn. @hzoo @sokra Is it worth taking the time to explore making the parser pluggable as part of this, rather than just a straight replacement? I started a fork quite a while ago attempting to use |
|
@hzoo Please review the following output log for errors: See complete report here. |
|
Discontinued, acorn seem to be faster |
|
Are you open to switch the parser for a more performant alternative? What’s the time spent parsing on average on a large project? I think the parser is the major bottleneck in current webpack build times |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Testing out babylon parser instead of acorn
Did you add tests for your changes?
No extra tests, more of an internal change (parser swap)
Summary
Use babylon for other syntax support