Fixup system - follow up on #4356 #4373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rewrite affected modules
2 tasks
sokra
requested changes
Feb 28, 2017
| @@ -1,5 +1,5 @@ | |||
| it("should polyfill System", function() { | |||
| if (typeof System === "object" && typeof System.register === "function") { | |||
| if (typeof System.register === "function") { | |||
There was a problem hiding this comment.
Why are changes to the tests necessary?
lib/ParserHelpers.js
Outdated
| parser.state.current.addVariable(name, expression, deps); | ||
| return true; | ||
| }; | ||
| module.exports = class ParserHelpers { |
There was a problem hiding this comment.
ParserHelpers is not a real class. Stay with the exports.addParsedVaraibleToModule style. It's more aligned with the future style export function addParsedVariableToModule().
test/cases/parsing/typeof/index.js
Outdated
| @@ -45,7 +45,6 @@ it("should not parse filtered stuff", function() { | |||
| if(typeof module === "undefined") module = require("fail"); | |||
| if(typeof module != "object") module = require("fail"); | |||
| if(typeof exports == "undefined") exports = require("fail"); | |||
| if(typeof System !== "object") exports = require("fail"); | |||
There was a problem hiding this comment.
Why are changes to the tests necessary?
typeof System should object in webpack.
|
reverted the refactor. |
|
changes are reverted. |
sokra
approved these changes
Feb 28, 2017
buildin/system.js
Outdated
| @@ -1,3 +1,6 @@ | |||
| /* global System */ | |||
| // "fix" for users of "System" global | |||
use webpacks "own" System polyfill, do not try to access a previously existing one. Instead make sure everything will be "shadowed" by the webpack System. thx @sokra for the help!
ljharb
approved these changes
Feb 28, 2017
sokra
approved these changes
Mar 1, 2017
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup on #4356
see there for detailed description