Add regexp for IgnorePlugin #4418
Conversation
|
|
|
@TheLarkInn This is my first contribution. Sorry if I am making some mistakes. Does this require some test addition? Is two commits ok or do I need to rebase into one? |
|
@Dean-Coakley Besides that, two commits are welcome. |
|
You can add a test in |
|
Let us know if you have problems with creating a test case. |
|
Yes, I will not be able to write a test without a lot of help. - No experience of writing any unit tests or anything. Very open to learning despite my lack of free time though. Sorry about this. |
|
First could I convince you to read test/README.md, and see if that helps? I just explains what all the different cases do and how to add one. And then I can personally help you through adding a new one if it still isn't clear. |
|
Let me see if I can give you an example to work with today. |
|
Might be difficult for me to find time to work on this for the next few days, but I'd love if you could give me some guidance. Thanks! |
|
The minimum test ratio has been reached. Thanks! |
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
|
finished through #4669 |
|
Yup, all good @timse . I don't think I would have figured that out anyway. Thanks. |
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
No not yet, not sure how. I
Summary
contextRegExp should be checked if it is provided in both cases: normal-module-factory and context-module-factory.
Other information
Should fix: #4415