Fix _done function not dealing with compilation being undefined #4828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
sokra
approved these changes
May 6, 2017
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
#3934 introduced a bug as the title says, this fixes that.
Did you add tests for your changes?
No, any pointer to where add this test too? It seems there are no tests for the watcher handler being called correctly with
err.Summary
This should land ASAP because currently webpack is broken for errors in some plugins.
Does this PR introduce a breaking change?
No.
Other information
None.