Typo in examples common chunk #4865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bebraw
approved these changes
May 13, 2017
sokra
requested changes
May 14, 2017
|
@PeterTeng Thanks for your update. I labeled the Pull Request so reviewers will review it again. @sokra Please review the new changes. |
|
@sokra Thanks for the review, I modified the |
sokra
approved these changes
May 15, 2017
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Typo fix
Did you add tests for your changes?
No, readme changes only
Summary
Fix typo in
examples/common-chunk-and-vendor-chunk/README.md"it it" => "it in"
Does this PR introduce a breaking change?
No