Use Promise only when chunk load is triggered #4923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sokra
force-pushed
the
bugfix/promise-later
branch
from
f828630
to
ff35fa4
Compare
don't use it in initialisation fixes #4916
sokra
force-pushed
the
bugfix/promise-later
branch
from
ff35fa4
to
09d9533
Compare
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
timse
reviewed
May 25, 2017
| this.indent([ | ||
| "return resolvedPromise;" | ||
| "return new Promise(function(resolve) { resolve(); });" |
There was a problem hiding this comment.
can't this just be Promise.resolve() ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
no
If relevant, link to documentation update:
n/a
Summary
Use Promise only when chunk load is triggered
don't use it in initialisation
fixes #4916
Does this PR introduce a breaking change?
no
Other information