Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sortable set #5083

Merged
merged 10 commits into from
Jun 21, 2017
Merged

Sortable set #5083

merged 10 commits into from
Jun 21, 2017

Commits on Jun 18, 2017

  1. add SortableSet as a new collection type

    @timse
    timse committed Jun 18, 2017
    Configuration menu
    Copy the full SHA
    0eaa847 View commit details
    Browse the repository at this point in the history

  2. use SortableSet in chunks 

    use SortableSet to keep "_modules" sorted
    @timse
    timse committed Jun 18, 2017
    Configuration menu
    Copy the full SHA
    747efca View commit details
    Browse the repository at this point in the history

  3. use SortableSet in modules 

    use SortableSet to keep "_chunks" sorted
    @timse
    timse committed Jun 18, 2017
    Configuration menu
    Copy the full SHA
    4e5ef0d View commit details
    Browse the repository at this point in the history

  4. make sure ConcatenatedModules also uses SortedSet 

    fix tests that was falsy - per default chunks are flagged as sorted in module
however this only holds true as they are initialized empty. Concatenated module however
has initial modules and therefore is not guaranteed to be ordered, the flags should therfor be false.
Using SortedSet fixes this as a sideeffect
    @timse
    timse committed Jun 18, 2017
    Configuration menu
    Copy the full SHA
    bd8c6cf View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2017

  1. make sort function private

    @timse
    timse committed Jun 19, 2017
    Configuration menu
    Copy the full SHA
    1a16a3e View commit details
    Browse the repository at this point in the history

  2. optimize sortableSet to prevent unnecessary sorting

    @timse
    timse committed Jun 19, 2017
    Configuration menu
    Copy the full SHA
    7a99930 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2017

  1. allow to set chunks and use it in ConcatenatedModule

    @timse
    timse committed Jun 20, 2017
    Configuration menu
    Copy the full SHA
    f7ffed8 View commit details
    Browse the repository at this point in the history

  2. clean up SortableSet 

    - remove unnecessary _isSorted flag
- remove clear-override as an empty set is "sorted"
- early return on empty sets
    @timse
    timse committed Jun 20, 2017
    Configuration menu
    Copy the full SHA
    5f16dd8 View commit details
    Browse the repository at this point in the history

  3. add tests for sortableset

    @timse
    timse committed Jun 20, 2017
    Configuration menu
    Copy the full SHA
    b2a4244 View commit details
    Browse the repository at this point in the history

  4. fix linting/formatting issues

    @timse
    timse committed Jun 20, 2017
    Configuration menu
    Copy the full SHA
    8f3d65a View commit details
    Browse the repository at this point in the history