Fixes #5843 #5849
Merged
Fixes #5843 #5849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I'm awaiting a review of the CLA by my company. I will sign it when the review is complete. |
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
|
I have signed the CLA. |
|
@sokra it looks like automation has rejected the current change, but I'm not familiar enough with the state of the project (particularly: code coverage) to know how actionable this rejection is. Code coverage may have gone down due to the Can you advise? |
|
@sokra friendly ping on this. |
|
@sokra yet another friendly ping. |
|
The CI doesn't like to run correctly... |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR introduces a bugfix
Did you add tests for your changes?
Yes.
If relevant, link to documentation update:
N/A
Summary
Please refer to #5843 for a description of the bug and motivation for the change.
Does this PR introduce a breaking change?
No.