Make use of webpack-cli in webpack

[evenstensberg]

@sokra this is ready for a final review now. @shellscape needs to verify it doesn’t break the dev-server

[evenstensberg]

Facebook aren't willing to upgrade jscodeshift to get rid of the warning ( see: facebook/jscodeshift#198 (comment) )

[shellscape]

@ev1stensberg i'll prob have a chance to check this out on 10/22 EDT. the one big thing we'll have to look for is the options validation stuff, which WDS piggybacks on.

[sokra]

Could you not remove the binCases in this PR?

These tests should continue to work when webpack-cli is added.

[evenstensberg]

If you've hardcoded some logic in the dev-server, the CLI has a lot of the same logic where it used to be @shellscape

[evenstensberg]

@sokra any idea why the tests are failing? Might be https://github.com/webpack/webpack-cli/blob/master/bin/webpack.js#L28-L32

[evenstensberg]

weird..

[evenstensberg]

@sokra Tests should run fine now, added a .nsprc to avoid breaking the build every time.

• https://github.com/nodesecurity/nsp#exceptions

• https://nodesecurity.io/advisories/118

[evenstensberg]

@shellscape webpack/webpack-dev-server#1163

Anything else that needs attention?

[sokra]

Looks good.

[sokra]

Is this fixes? Could you remove this file?

[evenstensberg]

it will make the nsp check succeed

[evenstensberg]

@sokra what do you wanna do about the security issue? Adding a nsprc will make the CI pass

[evenstensberg]

@sokra CLI is resynced against the next branch again. Before merging, any potential changes to binTestCases or the /bin folder, could you also redirect them to the CLI repo, or chill them until the CLI gets merged? Avoids extra refactoring work

[sokra]

Before merging, any potential changes to binTestCases or the /bin folder, could you also redirect them to the CLI repo, or chill them until the CLI gets merged? Avoids extra refactoring work

I try to.

[sokra]

After a long fight js-codeshift was updated...

So we can merge this PR once dependencies are updated in webpack-cli resp. lockfiles in this PR.

[webpack-bot]

@ev1stensberg Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@sokra Please review the new changes.

[webpack-bot]

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

[evenstensberg]

CI build failed on yarn/cache, but I think this is ready now @sokra

[sokra]

Awesome ❤️