Deprecate forEach* and map* methods #6367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ooflorent
force-pushed
the
deprecate_forEach_map
branch
from
5d8086d
to
77d68f0
Compare
sokra
approved these changes
Jan 23, 2018
lib/Chunk.js
Outdated
| configurable: false, | ||
| value: util.deprecate(function(fn) { | ||
| this._modules.forEach(fn); | ||
| }, "Chunk.forEachModule: Use chunk.modulesIterable.forEach(fn) instead") |
There was a problem hiding this comment.
Use for(const module of chunk.modulesIterable) instead
An iterable has no forEach method. Here a Set is returned but you can't rely on that. The official return type is Iterable.
There was a problem hiding this comment.
I’ll update the wording.
lib/Module.js
Outdated
| configurable: false, | ||
| value: util.deprecate(function(fn) { | ||
| this._chunks.forEach(fn); | ||
| }, "Module.forEachChunk: Use module.chunksIterable.forEach(fn) instead") |
ooflorent
force-pushed
the
deprecate_forEach_map
branch
from
77d68f0
to
77bb4c0
Compare
|
@ooflorent Thanks for your update. I labeled the Pull Request so reviewers will review it again. @sokra Please review the new changes. |
sokra
approved these changes
Jan 23, 2018
TheLarkInn
approved these changes
Jan 23, 2018
|
Outdated uglify plugin or stuck test? |
|
@TheLarkInn CI fails at least one to 3 times on node 6 (😡 ) with timeouts or UglifyJS glitches. CI is not stable for node 6 on |
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
refactoring
Did you add tests for your changes?
no
If relevant, link to documentation update:
TODO
Summary
forEach*andmap*methods are not needed and add complexity to webpack. Since these modules could be replaced byArray.from(), there are safe to deprecate.Does this PR introduce a breaking change?
no