fix: validation error when ! is in the path

[byzyk]

What kind of change does this PR introduce?

bugfix

Did you add tests for your changes?

yes

If relevant, link to documentation update:

• TODO: possibly add a warning here https://webpack.js.org/configuration/output/#output-path

Summary

Throw validation error when ! was found in a path.
Closes #6742, closes #5320.

Does this PR introduce a breaking change?

no

Other information

[byzyk]

Hi @sokra, I fixed regexp inside absolute path validator to be able to check if there is ! present in a path.

However, I can't test my changes because it seems no matter what I do in schemas/ajv.absolutePath.js it doesn't reflect. For example, I tried to change the error message but it had no effect. It's not the package linking problem I checked that a couple of times already.

Please advice are there any extra steps required to make this work or am I missing something?

[chengluyu]

I think you should add a new message when ! is included in absolute path. Here's my solution.

p.s. I wonder why people don't use path.isAbsolute.

[montogeek]

Why code format changed?

[alexander-akait]

@montogeek prettier

[montogeek]

I understand that src code was already formatted with prettier, he didn't changed anything to increment line width

[ooflorent]

This file never was reformatted by prettier.

[sokra]

looks like the schemas folder is not included in the prettier scripts.

[byzyk]

Yes, the file was never formatted, when I first opened it there were 19 ESLint violations.

[sokra]

Create a separate message explaining that ! should not be used and why when it's used.

It should disallow ! independent of the expected value.

[webpack-bot]

@byzyk Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@sokra Please review the new changes.

[webpack-bot]

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

[byzyk]

hey @sokra, I resolved some conflicts, does it look ok to be merged now?

Also, what would be the right place for docs update? Should we add a warning in all related places (eg. output.path, output.filename)?