-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Chunks is not iterable when using source maps with ProfilingPlugin #6788
Conversation
The problem is that in I tried to fix it by defaulting chunks to context when no context is specified but it feels like a dirty fix to me and something for sure is not working smoothly. Any thoughts on this? |
That looks like a bug in webpack/tapable... |
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
Could you add a test? |
@sokra added a test case for |
Thanks for the test case. I removed your hack and fixed the bug, which was in the implementation of the ProfilingPlugin. I was not a bug in tapable. |
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
yes, for
configCases
If relevant, link to documentation update:
N/A
Summary
Fixes #6779
Does this PR introduce a breaking change?
no
Other information