Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES6 support #683

Closed
wants to merge 1 commit into from
Closed

ES6 support #683

wants to merge 1 commit into from

Conversation

sokra
Copy link
Member

@sokra sokra commented Jan 12, 2015

@@ -4,7 +4,7 @@
"author": "Tobias Koppers @sokra",
"description": "Packs CommonJs/AMD modules for the browser. Allows to split your codebase into multiple bundles, which can be loaded on demand. Support loaders to preprocess files, i.e. json, jade, coffee, css, less, ... and your custom stuff.",
"dependencies": {
"esprima": "~1.2.0",
"esprima-fb": "^8001.2001.0-dev-harmony-fb",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I saw NPM 2.0 erroring on this kind of thing since it's not allowed to reference -dev versions in new semver. Not sure though.

@sokra
Copy link
Member Author

sokra commented Jan 13, 2015

hmm... We need to redesign this to get all advantages of ES6 modules. Instead of tracking which module is requested, we need to track which export is requested. That way we can optimize away unused imports/exports and remove modules that only reexport (which is a common pattern for package entries, i. e. react-router)

@jhnns
Copy link
Member

jhnns commented Jan 13, 2015

Instead of tracking which module is requested, we need to track which export is requested.

👍

@gaearon
Copy link
Contributor

gaearon commented Jan 13, 2015

This would be rad.

@sebmck
Copy link

sebmck commented Jan 15, 2015

I'd recommend using acorn over esprima. It has far better ES6 support, and is much faster.

@zxcabs
Copy link

zxcabs commented Feb 20, 2015

What about System? for example: https://github.com/systemjs/systemjs

@jhnns
Copy link
Member

jhnns commented Feb 20, 2015

System has nothing to do with ES6 support as far as I read it out.

@zxcabs
Copy link

zxcabs commented Feb 20, 2015

System is a part of ES6

Look par.8 http://www.2ality.com/2014/09/es6-modules-final.html

@sokra
Copy link
Member Author

sokra commented Feb 20, 2015

System.import can act as Code Splitting point.

System.set System.define System.module propably won't be supported...

@jhnns
Copy link
Member

jhnns commented Feb 22, 2015

@zxcabs Ah, you were talking about the ES6 System. I've understood it as answer on @sebmck 's post and thought you were suggesting that systemjs should somehow be used by webpack.

@simonzack
Copy link
Contributor

Agree with @sebmck. esprima support will likely take some time. Acorn also uses the mozilla parser API..

@sokra
Copy link
Member Author

sokra commented Mar 5, 2015

closed in favor of #857

@sokra sokra closed this Mar 5, 2015
@sokra sokra deleted the harmony branch April 21, 2015 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants