Use 'Reflect.defineProperty' instead of 'Object.defineProperty'

[ooflorent]

What kind of change does this PR introduce?

refactoring

Did you add tests for your changes?

no

If relevant, link to documentation update:

n/a

Summary

Reflect.defineProperty is more meaningful than Object.defineProperty. Internally Reflect.dP performs less checks than Object.dP.

Use Object.defineProperty

Does this PR introduce a breaking change?

no

[webpack-bot]

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

[Jessidhia]

Semantically, Reflect is intended to be used from Proxy traps. You're supposed to return the result of Reflect.defineProperty from a default defineProperty Proxy trap.

I'm not sure you should be using it in non-Proxy-related code.

[sokra]

I changed my mind on this one (thanks @Kovensky for pointing this out).

The difference between Reflect and Object.defineProperty is that Object.defineProperty throws if the operation fails. (Reflect.defineProperty returns false)

So what's the behavior we want here? In my opinion we want an error to be thrown if the property can't be defined. An error here indicates that something is wrong here. We don't want this to be silently ignored...

[webpack-bot]

@ooflorent Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@sokra Please review the new changes.

[sokra]

Thanks