Change internal representation of harmony export modes #6953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ooflorent
force-pushed
the
refactor/mode_deopt
branch
from
ef52de7
to
0596346
Compare
sokra
requested changes
Apr 4, 2018
| @@ -246,6 +233,7 @@ class HarmonyExportImportedSpecifierDependency extends HarmonyImportDependency { | |||
| }; | |||
|
|
|||
| default: | |||
| console.log(mode); | |||
|
@ooflorent Thanks for your update. I labeled the Pull Request so reviewers will review it again. @sokra Please review the new changes. |
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
sokra
approved these changes
Apr 4, 2018
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
refactoring
Did you add tests for your changes?
no
If relevant, link to documentation update:
N/A
Summary
This change make
getReferencemonomorphic sincegetModewill always return anExportMode. By doing this, all modes share the same shape.Does this PR introduce a breaking change?
no