Fix LoaderPlugin not resolving recursively #7059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
sokra
approved these changes
Apr 17, 2018
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
Yes, although I'm not entirely sure if there are already tests which could simply be changed or if my new tests should to be moved to a different folder.
If relevant, link to documentation update:
...
Summary
Fixes #4959
loaderContext.loadModulecurrently doesn't resolve modules recursively, which leads to unresolved dependencies when the modules loaded by the loader get loaded regularly later on.Without the changes made in LoaderPlugin.js, the provided tests fail.
Does this PR introduce a breaking change?
No
Other information
#6517 intended to fix the issue, but its tests failed.