Clone optimization config in Defaulter #7063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ooflorent
approved these changes
Apr 17, 2018
Jessidhia
approved these changes
Apr 17, 2018
| @@ -193,6 +193,7 @@ class WebpackOptionsDefaulter extends OptionsDefaulter { | |||
| options => (isProductionLikeMode(options) ? "warning" : false) | |||
| ); | |||
|
|
|||
| this.set("optimization", "call", value => Object.assign({}, value)); | |||
There was a problem hiding this comment.
Why does this one need Object.assign({}, value) instead of just defaulting to {} like its subkeys? Or is that something that is needed only on all top-level objects?
There was a problem hiding this comment.
Or is that something that is needed only on all top-level objects?
Yep, it basically clones all modified objects
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
yes
If relevant, link to documentation update:
N/A
Summary
we forgot to clone the
optimizationconfig in the DefaulterDoes this PR introduce a breaking change?
no
Other information
problem found in #6565