Feature/main template type support #7116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
niieani
reviewed
May 1, 2018
lib/MainTemplate.js
Outdated
| /** | ||
| * | ||
| * @param {any} options render manifest options | ||
| * @returns {any[]} returns render nanifest |
There was a problem hiding this comment.
Lmaooooo nanifest seems cooler though 😂
…l signatures for chunk and main templates
ooflorent
approved these changes
May 2, 2018
|
Rerunning CI with new TypeScript nightly now in master (which this was dependent on) |
|
Merging now that type errors and lint failures are gone, and with @ooflorent approval. |
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Typing JSDocs
Did you add tests for your changes?
N/A
If relevant, link to documentation update:
N/A
Summary
Add's Type support via JSDocs for MainTemplate class.
Does this PR introduce a breaking change?
No
Other information
This PR although may include TS nightly change in package.json actually relies on official version bump PR #7115