Fix regression in Compilation.sortModules

[jordwest]

What kind of change does this PR introduce?

Bugfix for regression introduced in #6203.

Did you add tests for your changes?

Yes

If relevant, link to documentation update:

N/A

Summary

This reverts the accidental change introduced in #6203 which sorted modules by id instead of index:

	sortModules(modules) {
-		modules.sort((a, b) => {
-			if(a.index < b.index) return -1;
-			if(a.index > b.index) return 1;
-			return 0;
-		});
+		modules.sort(byId);
	}

@sokra in #7194:

The change you found really looks incorrect. Looks like this was changed accidentally. Could you send a PR including a test case and change this back to index order.

the module.id is not available that this point, so that's wrong.

Does this PR introduce a breaking change?

No

Other information

[jsf-clabot]

All committers have signed the CLA.

[webpack-bot]

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

[TheLarkInn]

Great catch, and thank you for the contribution. 🙇

[sokra]

Thanks