fix: unsupported function defined inside a condition block. #7263

[aleen42]

Issue Reference

fixes #7263

What kind of change does this PR introduce?

Call the method onScriptComplete after its declaration as there should ben an error of references under Friefox 40, when it has been declared inside a conditon block, rather than the top block inside a function.

Did you add tests for your changes?

No needs.

Does this PR introduce a breaking change?

Solve the problem under Firefox 40.

What needs to be documented once your changes are merged?

No needs.

[jsf-clabot]

All committers have signed the CLA.

[webpack-bot]

For maintainers only:

• This need to be documented (issue in webpack/webpack.js.org will be filed when merged)

[aleen42]

A separate PR for fixing remaining problems of #7210.

[ooflorent]

function declarations are hoisted. This should not be an issue.

[ooflorent]

LGTM. However, please fix styling issues.

[aleen42]

@ooflorent hoisted function does not work inside condition block under FireFox.

[aleen42]

@ooflorent It seems like my fault, and the result should not be an issue, as it has been executed within another event loop:

[sokra]

So we can close it?

[aleen42]

It depends on you all. In my opinion, it is still not proper to declare function inside a condition block, a.k.a inner-declaration, according to a document of ESLint, and I will submit another commit for this, and revert the commit of #7210.

[webpack-bot]

@aleen42 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@sokra Please review the new changes.

[aleen42]

Hoisted variables should be avoided, like using let or const within ES6, rather than var.

[aleen42]

@sokra It seems that the "stats test cases" has not already been matched?

[webpack-bot]

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

[ooflorent]

function onScriptComplete(event) { was fine

[aleen42]

As an inner declaration, it was not fine to some extends.

[aleen42]

https://eslint.org/docs/rules/no-inner-declarations

[webpack-bot]

Hi @aleen42.

Just a little hint from a friendly bot about the best practice when submitting pull requests:

Don't submit pull request from your own master branch. It's recommended to create a feature branch for the PR.

You don't have to change it for this PR, just make sure to follow this hint the next time you submit a PR.

[sokra]

Ok let's use that

[sokra]

@aleen42 please also sign the CLA

[aleen42]

I have signed it and can u check this? @sokra

[sokra]

Thanks