Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump webassemblyjs #7501

Merged
merged 1 commit into from
Jun 7, 2018
Merged

Conversation

xtuc
Copy link
Member

@xtuc xtuc commented Jun 7, 2018

What kind of change does this PR introduce?

Did you add tests for your changes?

Does this PR introduce a breaking change?

What needs to be documented once your changes are merged?

Closes #7495

We have now a check into our CI: xtuc/webassemblyjs#389

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This need to be documented (issue in webpack/webpack.js.org will be filed when merged)

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@sokra sokra merged commit ebe90f4 into webpack:master Jun 7, 2018
@sokra
Copy link
Member

sokra commented Jun 7, 2018

Thanks

@xtuc xtuc deleted the chore-bump-webassemblyjs9 branch June 7, 2018 14:21
chaseholland pushed a commit to chaseholland/haul that referenced this pull request Jun 7, 2018
chaseholland pushed a commit to chaseholland/haul that referenced this pull request Jun 18, 2018
thymikee pushed a commit to callstack/haul that referenced this pull request Jun 20, 2018
* making babelRegister work with pnpm package structure

* adding babel polyfill dep

* switching to webpack master to resolve pnpm issue fixed here webpack/webpack#7501

* adding correct urls from chrome debugging

* setting webpack to a release version with pnpm fix

* updating test snapshots after config change

* removing unneeded escape char in babelRegister
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation fails when installed via pnpm: Error: Cannot find module '@webassemblyjs/utf8'
3 participants