CommentCompilationWarning typings #7532
Conversation
|
For maintainers only:
|
lib/CommentCompilationWarning.js
Outdated
| * @property {number} line | ||
| */ | ||
|
|
||
| /** @typedef {Object} Loc |
There was a problem hiding this comment.
Should I add @property {number=} index to @typedef {Object} Loc like in compareLocations.js ==> @typedef {Object} NodeLocation ?
There was a problem hiding this comment.
@mohsen1 The Loc type I have defined here is used in several locations, is there a way to not typedef it over and over again, but just import it from a common definition file?
There was a problem hiding this comment.
You can import typedefs from other files. Maybe the best place is in ``Dependency.js`
There was a problem hiding this comment.
@ooflorent Can you make a comment on sokras comment?
There was a problem hiding this comment.
Importing types from Dependency class makes sense.
There was a problem hiding this comment.
Please review the changes i made, advise appreciated. I have commited this change, but I have TS errors
Actually, I have no clue how to do this ;-)
lib/CommentCompilationWarning.js
Outdated
| * @property {number} line | ||
| */ | ||
|
|
||
| /** @typedef {Object} Loc |
There was a problem hiding this comment.
You can import typedefs from other files. Maybe the best place is in ``Dependency.js`
webpack-bot
added
PR: reviewed-changes-requested
PR: CI-ok
and removed
PR: unreviewed
labels
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-changes-requested
labels
lib/Dependency.js
Outdated
| * @property {Position} end | ||
| */ | ||
|
|
||
| exports Position; |
There was a problem hiding this comment.
you don't need to export types
There was a problem hiding this comment.
I'll remove the exports.. and leave everything as is.
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
lib/CommentCompilationWarning.js
Outdated
| @@ -6,7 +6,19 @@ | |||
|
|
|||
| const WebpackError = require("./WebpackError"); | |||
|
|
|||
| /** @typedef {import("./Module.js")} Module */ | |||
|
|
|||
| /** @typedef {import("./Dependency.js").Position} Position */ | |||
webpack-bot
added
PR: reviewed-changes-requested
and removed
PR: review-outdated
labels
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-changes-requested
labels
|
Thanks |
What kind of change does this PR introduce?
CommentCompilationWarning typings
Did you add tests for your changes?
no
Does this PR introduce a breaking change?
no
What needs to be documented once your changes are merged?
no