Implement all path variables for webworker dynamic imports

[TimHambourger]

Previously, not all path variables were implemented when doing dynamic imports and targeting webworker. See #7563.

What kind of change does this PR introduce?

A bugfix. WebWorkerMainTemplatePlugin.js was missing some required chunk attributes.

Did you add tests for your changes?

Yes. Though I do have questions about the test framework. I'll post those as a separate comment.

Does this PR introduce a breaking change?

No. Prior to this commit, unsupported path variables would either throw at compile time or produce unexpected import paths at runtime.

What needs to be documented once your changes are merged?

No new documentation needed.

[jsf-clabot]

All committers have signed the CLA.

[webpack-bot]

For maintainers only:

• This need to be documented (issue in webpack/webpack.js.org will be filed when merged)

[TimHambourger]

As I mention above, I have a few questions about my test.

I added a test under ConfigTestCases to verify that all documented path variables compile without exception when using dynamic imports and targeting web, webworker, node, or async-node.

As is, my test just verifies that compilation doesn't throw and skips test execution with testConfig.noTests. Initially, I tried to go further and have my test confirm that the constructed import paths work as expected at runtime. This ran into friction with the test harness, mostly around supporting web and webworker targets. I'm happy to go into more details if that'd be helpful.

So mainly I'm wondering: Would you see the fuller test as valuable? If so, can we discuss ways to resolve the friction I ran into?

Thanks!

[webpack-bot]

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

[TimHambourger]

Oh, one more thought: It looks like there's an opportunity to re-use the code for formatting the dynamic import's path. I see 4 copies of it currently. It looks straightforward to add a method on MainTemplate like getDynamicImportPathExpr(chunk, chunkIdExpr) that would return a JS expr, as a string, for computing the import path from the chunkId. Usage (in WebWorkerMainTemplatePlugin) could be like

Template.ident([
    "importScript(" +
        mainTemplate.getDynamicImportPathExpr(chunk, "chunkId") +
    ");"
])

Does that seem like a good approach? If so, I'm happy to amend this PR or create a new one.

Thanks!

[webpack-bot]

Hi @TimHambourger.

Just a little hint from a friendly bot about the best practice when submitting pull requests:

Don't submit pull request from your own master branch. It's recommended to create a feature branch for the PR.

You don't have to change it for this PR, just make sure to follow this hint the next time you submit a PR.

[sokra]

Thanks