hook into dependency reference #7585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For maintainers only:
|
expose DependencyReference class
sokra
force-pushed
the
feature/hook-into-get-reference
branch
from
13efa46
to
3502287
Compare
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
icarlossz
approved these changes
Jun 24, 2018
ooflorent
changed the title
ooflorent
approved these changes
Jun 25, 2018
|
@sokra Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ooflorent Please review the new changes. |
ooflorent
approved these changes
Jun 27, 2018
icarlossz
approved these changes
Jun 28, 2018
|
I've created an issue to document this in webpack/webpack.js.org. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add Compilation.getDependencyReference and hooks to override it
What kind of change does this PR introduce?
refactoring, feature
Did you add tests for your changes?
yes
Does this PR introduce a breaking change?
no
What needs to be documented once your changes are merged?
New hook
Compilation.hooks.dependencyReference(depRef, dependency, module)was added.it allows to change the references reported by dependencies