New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(pgk): add update-snapshot script for all tests #7604
Conversation
For maintainers only:
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
package.json
Outdated
@@ -104,6 +104,7 @@ | |||
"scripts": { | |||
"setup": "node ./setup/setup.js", | |||
"test": "node --max-old-space-size=4096 --trace-deprecation node_modules/jest-cli/bin/jest", | |||
"test:update-snapshots": "yarn test -u", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you change this to yarn jest -u
? yarn test
also runs the linting and this is not needed here.
I'll merge once final check runs. |
Thanks |
This PR adds a very simple update-snapshot script. This enables a contributor to run:
I also updated the SETUP.md guide to reflect this change.
What kind of change does this PR introduce?
Build related change
Did you add tests for your changes?
N/A
Does this PR introduce a breaking change?
N/A
What needs to be documented once your changes are merged?
N/A