Add JSDoc types for ContextExclusionPlugin #7658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For maintainers only:
|
ooflorent
reviewed
Jul 5, 2018
lib/ContextExclusionPlugin.js
Outdated
| apply(compiler) { | ||
| compiler.hooks.contextModuleFactory.tap("ContextExclusionPlugin", cmf => { | ||
| compiler.hooks.contextModuleFactory.tap("ContextExclusionPlugin", ( | ||
| /** @type {ContextModuleFactory} */ cmf |
There was a problem hiding this comment.
Why is it required? Should't compiler.hooks.contextModuleFactory be typed?
There was a problem hiding this comment.
Good question. Let me check
sokra
requested changes
Jul 11, 2018
lib/ContextExclusionPlugin.js
Outdated
| apply(compiler) { | ||
| compiler.hooks.contextModuleFactory.tap("ContextExclusionPlugin", cmf => { | ||
| compiler.hooks.contextModuleFactory.tap("ContextExclusionPlugin", ( | ||
| /** @type {ContextModuleFactory} */ cmf |
…tExclusionPlugin-types
webpack-bot
added
PR: review-outdated
PR: CI-not-ok
and removed
PR: reviewed-changes-requested
PR: CI-ok
labels
…tExclusionPlugin-types
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
sokra
approved these changes
Jul 17, 2018
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.