Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade jest #7699

Merged
merged 2 commits into from
Jul 10, 2018
Merged

upgrade jest #7699

merged 2 commits into from
Jul 10, 2018

Conversation

sokra
Copy link
Member

@sokra sokra commented Jul 10, 2018

Seem like jest has a windows bug and a hidden breaking change in this minor version. We need to change all test cases with namespace objects according to this.
Previously toEqual didn't care about enumerable-attribute of symbolic properties. Now it does care.

What kind of change does this PR introduce?
upgrade

Did you add tests for your changes?
existing tests

Does this PR introduce a breaking change?
no

What needs to be documented once your changes are merged?
nothing

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This need to be documented (issue in webpack/webpack.js.org will be filed when merged)

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@sokra sokra merged commit 365beb1 into master Jul 10, 2018
@sokra sokra deleted the ci/upgrade-jest branch July 10, 2018 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants