fix order of occurrence order plugin #7721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove enforced additional occurrence order plugin from test cases make test cases more independent of module/chunk order/ids
|
For maintainers only:
|
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
ooflorent
reviewed
Jul 14, 2018
| @@ -124,7 +124,7 @@ class OccurrenceOrderPlugin { | |||
| if (aOccurs < bOccurs) return 1; | |||
| const orgA = originalOrder.get(a); | |||
| const orgB = originalOrder.get(b); | |||
| return orgB - orgA; | |||
There was a problem hiding this comment.
It looks like this sort algorithm is used multiple times. Maybe it could be extracted and shared across the other plugins.
There was a problem hiding this comment.
yep, I look into refactoring this for webpack 5.
ooflorent
approved these changes
Jul 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove enforced additional occurrence order plugin from test cases
make test cases more independent of module/chunk order/ids
The OccurrenceOrderPlugin should keep original order when occurrence count is equal, but instead it used the inverted order. This is now fixed.
Also the duplicate OccurrenceOrderPlugin in the StatsTestCases was removed.
What kind of change does this PR introduce?
bugfix, test update
Did you add tests for your changes?
existing tests
Does this PR introduce a breaking change?
no
What needs to be documented once your changes are merged?
nothing