Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor define before use class #7823

Merged
merged 1 commit into from
Jul 31, 2018
Merged

Refactor define before use class #7823

merged 1 commit into from
Jul 31, 2018

Conversation

flyyang
Copy link
Contributor

@flyyang flyyang commented Jul 31, 2018

What kind of change does this PR introduce?
Refactoring.

Did you add tests for your changes?
Not necessary .

Does this PR introduce a breaking change?
No.

What needs to be documented once your changes are merged?
Nothing.

@jsf-clabot
Copy link

jsf-clabot commented Jul 31, 2018 •
edited

CLA assistant check
All committers have signed the CLA.

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This need to be documented (issue in webpack/webpack.js.org will be filed when merged)

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@sokra sokra closed this Jul 31, 2018
@sokra sokra reopened this Jul 31, 2018
@sokra sokra merged commit 32fdca2 into webpack:master Jul 31, 2018
@sokra
Copy link
Member

sokra commented Jul 31, 2018

Thanks

@flyyang flyyang deleted the refactor/define-before-use-class branch July 31, 2018 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra approved these changes

Assignees
No one assigned
Labels
PR: CI-ok PR: reviewed-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@flyyang @jsf-clabot @webpack-bot @sokra