fixes 7778: query string in dynamic import() #7839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
For maintainers only:
|
Remove name from test
remove prepend in favor of replaces improve code style in ContextDependencyHelpers
sokra
changed the title
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
|
Thanks |
|
Thanks! Sorry I couldn't help more! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will hopefully end up fixing a bug where queryStrings are affecting the way imports are treated
#7778
What kind of change does this PR introduce?
(bugfix) Although currently just adds a failing test case, I think the problem lies somewhere inside ImportParserPlugin -> ContextDependencyHelpers but thats as far as I've gotten. Any help would be greatly appreciated
Did you add tests for your changes?
Yes (hopefully they are fine)
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
It will hopefully correct existing documented functionality