Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solving outputing unnecessary spaces #7961

Merged
merged 1 commit into from
Sep 2, 2018
Merged

solving outputing unnecessary spaces #7961

merged 1 commit into from
Sep 2, 2018

Conversation

a1mersnow
Copy link
Contributor

@a1mersnow a1mersnow commented Aug 28, 2018

is causing terminals like git bash on windows to output unnecessary spaces

What kind of change does this PR introduce?

a bugfix

Did you add tests for your changes?

no

Does this PR introduce a breaking change?

no

What needs to be documented once your changes are merged?

nothing

`…` is causing terminals like git bash on windows to output unnecessary spaces
@jsf-clabot
Copy link

jsf-clabot commented Aug 28, 2018

CLA assistant check
All committers have signed the CLA.

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This need to be documented (issue in webpack/webpack.js.org will be filed when merged)

@sokra
Copy link
Member

sokra commented Aug 28, 2018

cc @ooflorent see also #6833

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@ooflorent
Copy link
Member

While I'm okay with this change, I'm unable to reproduce the issue in Git Bash so I'm skeptical… Are you sure that this change fix the issue? Have you tried using the latest Git Bash / cygwin? Isn't it to related to the terminal encoding?

@a1mersnow
Copy link
Contributor Author

@ooflorent I tried in lastest git bash and cmd and powershell(on Windows10), there are unnecessary spaces. However, when I tried in WSL, the spaces disappeared. And, when I replace with ..., the spaces also disappeared.
I think this is because occupy two char's position, you can tried process.stdout.write('…\b…\b…\babc') in node REPL on different environments.

Thanks

@webpack-bot
Copy link
Contributor

It looks like this Pull Request doesn't include enough test cases (based on Code Coverage analysis of the PR diff).

A PR need to be covered by tests if you add a new feature (we want to make sure that your feature is working) or if you fix a bug (we want to make sure that we don't run into a regression in future).

@aimergenge Please check if this is appliable to your PR and if you can add more test cases.

Read the test readme for details how to write test cases.

@a1mersnow
Copy link
Contributor Author

I don't know how to add tests for this. Anyone can help?

@sokra
Copy link
Member

sokra commented Aug 29, 2018

I don't know how to add tests for this. Anyone can help?

You don't need to test this, but make sure to sign the CLA

@a1mersnow
Copy link
Contributor Author

a1mersnow commented Aug 30, 2018

I have signed it, is there other things I need to do?

Sorry, I'm a noob of github.

@mengxk2018
Copy link

Just occured same issue and opened it, then i found it is duplication issue,I really try search before I open. Fixed it at line: 6

@sokra sokra merged commit 80bc330 into webpack:master Sep 2, 2018
@sokra
Copy link
Member

sokra commented Sep 2, 2018

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Progress message showing many spaces --progress cause console to mess around
6 participants