-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solving outputing unnecessary spaces #7961
Conversation
`…` is causing terminals like git bash on windows to output unnecessary spaces
For maintainers only:
|
cc @ooflorent see also #6833 |
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
While I'm okay with this change, I'm unable to reproduce the issue in Git Bash so I'm skeptical… Are you sure that this change fix the issue? Have you tried using the latest Git Bash / cygwin? Isn't it to related to the terminal encoding? |
@ooflorent I tried in lastest git bash and cmd and powershell(on Windows10), there are unnecessary spaces. However, when I tried in WSL, the spaces disappeared. And, when I replace Thanks |
It looks like this Pull Request doesn't include enough test cases (based on Code Coverage analysis of the PR diff). A PR need to be covered by tests if you add a new feature (we want to make sure that your feature is working) or if you fix a bug (we want to make sure that we don't run into a regression in future). @aimergenge Please check if this is appliable to your PR and if you can add more test cases. Read the test readme for details how to write test cases. |
I don't know how to add tests for this. Anyone can help? |
You don't need to test this, but make sure to sign the CLA |
I have signed it, is there other things I need to do? Sorry, I'm a noob of github. |
Just occured same issue and opened it, then i found it is duplication issue,I really try search before I open. Fixed it at line: 6 |
Thanks |
…
is causing terminals like git bash on windows to output unnecessary spacesWhat kind of change does this PR introduce?
a bugfix
Did you add tests for your changes?
no
Does this PR introduce a breaking change?
no
What needs to be documented once your changes are merged?
nothing