Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove webpack-command from CLIs #7966

Merged
merged 3 commits into from Sep 10, 2018

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Aug 29, 2018

What kind of change does this PR introduce?

refactoring

Did you add tests for your changes?

no required

Does this PR introduce a breaking change?

no

What needs to be documented once your changes are merged?

no

After merge need patch release and we archived webpack-command

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This need to be documented (issue in webpack/webpack.js.org will be filed when merged)

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@montogeek
Copy link
Member

A lot of other code could be refactored

@alexander-akait
Copy link
Member Author

alexander-akait commented Aug 29, 2018

@montogeek why? It will be helpful if we have other cli in future (example experemental)

@montogeek
Copy link
Member

@evilebottnawi Ok, sounds good

@edmorley
Copy link
Contributor

Does this mean webpack-command is now no longer going to (at least for simple use cases) replace webpack-cli? From the outside it's been hard to work out which of the two is recommended / what the long term road map is...

@alexander-akait
Copy link
Member Author

@edmorley long term is webpack-cli, webpack-command is will be proof of concept and many features already implemented in webpack-cli, some in WIP

@alexander-akait alexander-akait force-pushed the refactor-remove-webpack-command-from-clis branch from 83f2d10 to 898462d Compare September 4, 2018 19:17
@webpack-bot
Copy link
Contributor

@sokra Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@ooflorent Please review the new changes.

@sokra sokra merged commit 4430524 into master Sep 10, 2018
@sokra sokra deleted the refactor-remove-webpack-command-from-clis branch September 10, 2018 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants