Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove `webpack-command` from CLIs #7966

Merged
merged 3 commits into from Sep 10, 2018

Conversation

Projects
None yet
6 participants
@evilebottnawi
Copy link
Member

commented Aug 29, 2018

What kind of change does this PR introduce?

refactoring

Did you add tests for your changes?

no required

Does this PR introduce a breaking change?

no

What needs to be documented once your changes are merged?

no

After merge need patch release and we archived webpack-command

@webpack-bot

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2018

For maintainers only:

  • This need to be documented (issue in webpack/webpack.js.org will be filed when merged)
@webpack-bot

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2018

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@montogeek

This comment has been minimized.

Copy link
Member

commented Aug 29, 2018

A lot of other code could be refactored

@evilebottnawi

This comment has been minimized.

Copy link
Member Author

commented Aug 29, 2018

@montogeek why? It will be helpful if we have other cli in future (example experemental)

@montogeek

This comment has been minimized.

Copy link
Member

commented Aug 29, 2018

@evilebottnawi Ok, sounds good

@edmorley

This comment has been minimized.

Copy link
Member

commented Aug 30, 2018

Does this mean webpack-command is now no longer going to (at least for simple use cases) replace webpack-cli? From the outside it's been hard to work out which of the two is recommended / what the long term road map is...

@evilebottnawi

This comment has been minimized.

Copy link
Member Author

commented Aug 30, 2018

@edmorley long term is webpack-cli, webpack-command is will be proof of concept and many features already implemented in webpack-cli, some in WIP

@evilebottnawi evilebottnawi force-pushed the refactor-remove-webpack-command-from-clis branch from 83f2d10 to 898462d Sep 4, 2018

@webpack-bot

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2018

@sokra Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@ooflorent Please review the new changes.

@sokra

sokra approved these changes Sep 10, 2018

@sokra sokra merged commit 4430524 into master Sep 10, 2018

4 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
security/snyk - package.json (sokra) No new issues
Details

@sokra sokra deleted the refactor-remove-webpack-command-from-clis branch Sep 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.