fix(nodemaintemplate): resolve async chunk path platform agnostic #8035
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
closes #8032.
For
async-node
target, it creates template to resolve path to chunk bundles via string concat, ends up creating slash-mixed paths on windows platform, fail to some tools like vs code resolves correct sources. This PR updates template to usepath.resolve
instead to have platform agnostic path resolving behavior.getAssetPath
still generates using fixed separator in slashes, but let it just correctly resovled viapath.resolve
directly instead of trying to make changes to those logics.Did you add tests for your changes?
Does this PR introduce a breaking change?
No.
What needs to be documented once your changes are merged?