Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nodemaintemplate): resolve async chunk path platform agnostic #8035

Merged
merged 1 commit into from
Sep 15, 2018
Merged

fix(nodemaintemplate): resolve async chunk path platform agnostic #8035

merged 1 commit into from
Sep 15, 2018

Conversation

kwonoj
Copy link
Contributor

@kwonoj kwonoj commented Sep 14, 2018

What kind of change does this PR introduce?

closes #8032.

For async-node target, it creates template to resolve path to chunk bundles via string concat, ends up creating slash-mixed paths on windows platform, fail to some tools like vs code resolves correct sources. This PR updates template to use path.resolve instead to have platform agnostic path resolving behavior. getAssetPath still generates using fixed separator in slashes, but let it just correctly resovled via path.resolve directly instead of trying to make changes to those logics.

Did you add tests for your changes?

  • manually verified behavior, bit unsure where would be best to add test cases for this.

Does this PR introduce a breaking change?

No.

What needs to be documented once your changes are merged?

@jsf-clabot
Copy link

jsf-clabot commented Sep 14, 2018

CLA assistant check
All committers have signed the CLA.

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This need to be documented (issue in webpack/webpack.js.org will be filed when merged)

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@sokra sokra merged commit 5258471 into webpack:master Sep 15, 2018
@sokra
Copy link
Member

sokra commented Sep 15, 2018

Thanks

@kwonoj kwonoj deleted the fix-path branch September 17, 2018 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module loaded with mixed slashes on windows when target: 'electron-main'
4 participants